From 2bc7167adae7749aa5c4c3a8dae9766ceb64b8df Mon Sep 17 00:00:00 2001 From: "Dr.Lt.Data" Date: Sat, 11 Nov 2023 07:53:44 +0900 Subject: [PATCH] fix: In the share feature, only image formats are allowed. --- __init__.py | 2 +- js/comfyui-manager.js | 2 +- js/comfyui-share.js | 7 ++++++- 3 files changed, 8 insertions(+), 3 deletions(-) diff --git a/__init__.py b/__init__.py index f65f5f62..c18b0ab2 100644 --- a/__init__.py +++ b/__init__.py @@ -14,7 +14,7 @@ import concurrent import ssl from urllib.parse import urlparse -version = "V1.0" +version = "V1.0.1" print(f"### Loading: ComfyUI-Manager ({version})") diff --git a/js/comfyui-manager.js b/js/comfyui-manager.js index a26eec7d..914dec96 100644 --- a/js/comfyui-manager.js +++ b/js/comfyui-manager.js @@ -603,7 +603,7 @@ app.registerExtension({ const supported_nodes_string = SUPPORTED_OUTPUT_NODE_TYPES.join(", "); alert(`No supported output node found (${supported_nodes_string}). To share this workflow, please add an output node to your graph and re-run your prompt.`); } else { - alert("To share this, first run a prompt. Once it's done, click 'Share'."); + alert("To share this, first run a prompt. Once it's done, click 'Share'.\n\nNOTE: Images of the Share target can only be selected in the PreviewImage, SaveImage, and VHS_VideoCombine nodes. In the case of VHS_VideoCombine, only the image/gif and image/webp formats are supported."); } return; } diff --git a/js/comfyui-share.js b/js/comfyui-share.js index 4ce453b3..9ea8aef0 100644 --- a/js/comfyui-share.js +++ b/js/comfyui-share.js @@ -88,6 +88,11 @@ export function getPotentialOutputsAndOutputNodes(nodes) { const widgetValue = node.widgets[j].value; const parsedURLVals = widgetValue.params; + if(!parsedURLVals.format.startsWith('image')) { + // video isn't supported format + continue; + } + // ensure that the parsedURLVals have 'filename', 'subfolder', 'type', and 'format' properties if (parsedURLVals.hasOwnProperty("filename") && parsedURLVals.hasOwnProperty("subfolder") && parsedURLVals.hasOwnProperty("type") && parsedURLVals.hasOwnProperty("format")) { if (parsedURLVals.type !== "output") { @@ -509,7 +514,7 @@ export class ShareDialog extends ComfyDialog { const supported_nodes_string = SUPPORTED_OUTPUT_NODE_TYPES.join(", "); alert(`No supported output node found (${supported_nodes_string}). To share this workflow, please add an output node to your graph and re-run your prompt.`); } else { - alert("To share this, first run a prompt. Once it's done, click 'Share'."); + alert("To share this, first run a prompt. Once it's done, click 'Share'.\n\nNOTE: Images of the Share target can only be selected in the PreviewImage, SaveImage, and VHS_VideoCombine nodes. In the case of VHS_VideoCombine, only the image/gif and image/webp formats are supported."); } this.selectedOutputIndex = 0; this.close();