ComfyUI-Manager/comfyui_manager
Dr.Lt.Data 05e13e7233 fix: correct enabled state detection and improve test isolation
This commit includes two fixes that improve test suite reliability
and fix a production bug:

1. Production Fix (manager_core.py:1819):
   - Fixed enabled state detection in get_installed_nodepacks()
   - Changed from `is_enabled = not y.endswith('.disabled')` to `is_enabled = True`
   - Packages in custom_nodes/ (not in .disabled/) are always enabled
   - This was a real bug causing incorrect API responses

2. Test Isolation Fix (test_case_sensitivity_integration.py:299):
   - Added cleanup_test_env() at end of test_case_sensitivity_full_workflow
   - Prevents disabled packages from polluting subsequent tests
   - Fixes test_disable_package failure in parallel test execution

Test Results:
- Pass rate improved from 93.2% to 96.6%
- Fixed 2 test failures
- Remaining 2 failures are due to enable operation bugs (separate issue)

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>
2025-11-08 11:31:48 +09:00
..
2025-09-03 01:24:47 +09:00
2025-06-01 06:23:11 +09:00

ComfyUI-Manager: Core Backend (glob)

This directory contains the Python backend modules that power ComfyUI-Manager, handling the core functionality of node management, downloading, security, and server operations.

Directory Structure

  • glob/ - code for new cacheless ComfyUI-Manager
  • legacy/ - code for legacy ComfyUI-Manager

Core Modules

  • manager_core.py: The central implementation of management functions, handling configuration, installation, updates, and node management.
  • manager_server.py: Implements server functionality and API endpoints for the web interface to interact with the backend.

Specialized Modules

  • share_3rdparty.py: Manages integration with third-party sharing platforms.

Architecture

The backend follows a modular design pattern with clear separation of concerns:

  1. Core Layer: Manager modules provide the primary API and business logic
  2. Utility Layer: Helper modules provide specialized functionality
  3. Integration Layer: Modules that connect to external systems

Security Model

The system implements a comprehensive security framework with multiple levels:

  • Block: Highest security - blocks most remote operations
  • High: Allows only specific trusted operations
  • Middle: Standard security for most users
  • Normal-: More permissive for advanced users
  • Weak: Lowest security for development environments

Implementation Details

  • The backend is designed to work seamlessly with ComfyUI
  • Asynchronous task queuing is implemented for background operations
  • The system supports multiple installation modes
  • Error handling and risk assessment are integrated throughout the codebase

API Integration

The backend exposes a REST API via manager_server.py that enables:

  • Custom node management (install, update, disable, remove)
  • Model downloading and organization
  • System configuration
  • Snapshot management
  • Workflow component handling