From 9f23885266bdc88586fa4acc14268184b5c225c9 Mon Sep 17 00:00:00 2001 From: Robin Huang Date: Wed, 10 Apr 2024 12:22:44 -0700 Subject: [PATCH 1/6] Try GCS branch. --- .github/workflows/test-example-workflows.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/test-example-workflows.yml b/.github/workflows/test-example-workflows.yml index f2220f72b..76525ae5f 100644 --- a/.github/workflows/test-example-workflows.yml +++ b/.github/workflows/test-example-workflows.yml @@ -27,7 +27,7 @@ jobs: runs-on: ${{ matrix.runner_label }} steps: - name: Test Default Workflow - uses: drip-art/comfy-action@main + uses: drip-art/comfy-action@rh-gcs with: os: ${{ matrix.os }} cuda_version: ${{ matrix.cuda_version }} From b8a78f6b22b19883ac49545945da050f7359c8f8 Mon Sep 17 00:00:00 2001 From: Robin Huang Date: Wed, 10 Apr 2024 12:25:46 -0700 Subject: [PATCH 2/6] Add GCS credentails. --- .github/workflows/test-example-workflows.yml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/.github/workflows/test-example-workflows.yml b/.github/workflows/test-example-workflows.yml index 76525ae5f..af85dbcd7 100644 --- a/.github/workflows/test-example-workflows.yml +++ b/.github/workflows/test-example-workflows.yml @@ -34,6 +34,8 @@ jobs: models-json: '{"v1-5-pruned-emaonly.ckpt": {"url": "https://huggingface.co/runwayml/stable-diffusion-v1-5/resolve/main/v1-5-pruned-emaonly.ckpt", "directory": "checkpoints"}}' workflow_name: "default-workflow" workflow_json_path: '.github/workflows/json_examples/workflow_api.json' + gcs_bucket_name: 'comfyui' + google_credentials: ${{ secrets.GCS_SERVICE_ACCOUNT_JSON }} timeout: 50 - name: Test Lora Workflow uses: drip-art/comfy-action@main From b5d61bedfe11ca5d470b19432e38ffcec6d8eafb Mon Sep 17 00:00:00 2001 From: Robin Huang Date: Wed, 10 Apr 2024 12:41:34 -0700 Subject: [PATCH 3/6] Update bucket name. --- .github/workflows/test-example-workflows.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/test-example-workflows.yml b/.github/workflows/test-example-workflows.yml index af85dbcd7..8bd94a913 100644 --- a/.github/workflows/test-example-workflows.yml +++ b/.github/workflows/test-example-workflows.yml @@ -34,7 +34,7 @@ jobs: models-json: '{"v1-5-pruned-emaonly.ckpt": {"url": "https://huggingface.co/runwayml/stable-diffusion-v1-5/resolve/main/v1-5-pruned-emaonly.ckpt", "directory": "checkpoints"}}' workflow_name: "default-workflow" workflow_json_path: '.github/workflows/json_examples/workflow_api.json' - gcs_bucket_name: 'comfyui' + gcs_bucket_name: 'comfy-ci-results' google_credentials: ${{ secrets.GCS_SERVICE_ACCOUNT_JSON }} timeout: 50 - name: Test Lora Workflow From 5c385d2029bca1ebad21b78ec8f08483bd34f1e3 Mon Sep 17 00:00:00 2001 From: Robin Huang Date: Wed, 10 Apr 2024 16:11:23 -0700 Subject: [PATCH 4/6] Back to main. --- .github/workflows/test-example-workflows.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/test-example-workflows.yml b/.github/workflows/test-example-workflows.yml index 8bd94a913..5ba591925 100644 --- a/.github/workflows/test-example-workflows.yml +++ b/.github/workflows/test-example-workflows.yml @@ -27,7 +27,7 @@ jobs: runs-on: ${{ matrix.runner_label }} steps: - name: Test Default Workflow - uses: drip-art/comfy-action@rh-gcs + uses: drip-art/comfy-action@main with: os: ${{ matrix.os }} cuda_version: ${{ matrix.cuda_version }} From 52fbacbfc62cdcc444d8988c26a3263a624a0058 Mon Sep 17 00:00:00 2001 From: Robin Huang Date: Wed, 10 Apr 2024 16:15:24 -0700 Subject: [PATCH 5/6] Only run when run_test is in the comment. --- .github/workflows/test-example-workflows.yml | 17 ++++++----------- 1 file changed, 6 insertions(+), 11 deletions(-) diff --git a/.github/workflows/test-example-workflows.yml b/.github/workflows/test-example-workflows.yml index 5ba591925..bb20b4531 100644 --- a/.github/workflows/test-example-workflows.yml +++ b/.github/workflows/test-example-workflows.yml @@ -1,20 +1,15 @@ name: Test ComfyUI Example Workflows on: - pull_request: - branches: - - master - - dev - paths-ignore: - - 'tests/**' - - 'tests-ui/**' - push: - paths-ignore: - - 'tests/**' - - 'tests-ui/**' + issue_comment: + types: [created] workflow_dispatch: jobs: test-default-workflow: + if: >- + github.event_name == 'issue_comment' && + contains(github.event.comment.body, 'run_test') && + contains(fromJson('["WRITE", "MAINTAIN", "ADMIN"]'), github.event.comment.author_association) strategy: matrix: os: [macos, linux] From 3abee556112f727ec5cce7dc00186274bb0eb859 Mon Sep 17 00:00:00 2001 From: Robin Huang Date: Wed, 10 Apr 2024 16:16:25 -0700 Subject: [PATCH 6/6] Only run when comment is triggered. --- .github/workflows/windows-os-test.yml | 17 ++++++----------- 1 file changed, 6 insertions(+), 11 deletions(-) diff --git a/.github/workflows/windows-os-test.yml b/.github/workflows/windows-os-test.yml index 484058810..8c53f14e3 100644 --- a/.github/workflows/windows-os-test.yml +++ b/.github/workflows/windows-os-test.yml @@ -1,21 +1,16 @@ name: Test ComfyUI Windows with Default Workflow on: - pull_request: - branches: - - master - - dev - paths-ignore: - - 'tests/**' - - 'tests-ui/**' - push: - paths-ignore: - - 'tests/**' - - 'tests-ui/**' + issue_comment: + types: [created] workflow_dispatch: jobs: test-action: + if: >- + github.event_name == 'issue_comment' && + contains(github.event.comment.body, 'run_test') && + contains(fromJson('["WRITE", "MAINTAIN", "ADMIN"]'), github.event.comment.author_association) runs-on: Windows steps: - name: Use ComfyUI GitHub Action