add check for the format arg type in VideoFromComponents.save_to function (#11046)

* add check for the format var type in VideoFromComponents.save_to function

* convert "format" to VideoContainer enum
This commit is contained in:
Alexander Piskun 2025-12-02 21:50:13 +02:00 committed by GitHub
parent 44baa0b7f3
commit 33d6aec3b7
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 3 additions and 3 deletions

View File

@ -337,7 +337,7 @@ class VideoFromComponents(VideoInput):
if codec != VideoCodec.AUTO and codec != VideoCodec.H264: if codec != VideoCodec.AUTO and codec != VideoCodec.H264:
raise ValueError("Only H264 codec is supported for now") raise ValueError("Only H264 codec is supported for now")
extra_kwargs = {} extra_kwargs = {}
if format != VideoContainer.AUTO: if isinstance(format, VideoContainer) and format != VideoContainer.AUTO:
extra_kwargs["format"] = format.value extra_kwargs["format"] = format.value
with av.open(path, mode='w', options={'movflags': 'use_metadata_tags'}, **extra_kwargs) as output: with av.open(path, mode='w', options={'movflags': 'use_metadata_tags'}, **extra_kwargs) as output:
# Add metadata before writing any streams # Add metadata before writing any streams

View File

@ -88,7 +88,7 @@ class SaveVideo(io.ComfyNode):
) )
@classmethod @classmethod
def execute(cls, video: VideoInput, filename_prefix, format, codec) -> io.NodeOutput: def execute(cls, video: VideoInput, filename_prefix, format: str, codec) -> io.NodeOutput:
width, height = video.get_dimensions() width, height = video.get_dimensions()
full_output_folder, filename, counter, subfolder, filename_prefix = folder_paths.get_save_image_path( full_output_folder, filename, counter, subfolder, filename_prefix = folder_paths.get_save_image_path(
filename_prefix, filename_prefix,
@ -108,7 +108,7 @@ class SaveVideo(io.ComfyNode):
file = f"{filename}_{counter:05}_.{VideoContainer.get_extension(format)}" file = f"{filename}_{counter:05}_.{VideoContainer.get_extension(format)}"
video.save_to( video.save_to(
os.path.join(full_output_folder, file), os.path.join(full_output_folder, file),
format=format, format=VideoContainer(format),
codec=codec, codec=codec,
metadata=saved_metadata metadata=saved_metadata
) )