1383 Commits

Author SHA1 Message Date
comfyanonymous
19b6be0cf0 Don't try to use clip_fea on t2v model. 2025-02-26 08:38:09 -05:00
comfyanonymous
69c61c5063 Better wan memory estimation. 2025-02-26 07:51:22 -05:00
comfyanonymous
dfad9c897b More code reuse in wan.
Fix bug when changing the compute dtype on wan.
2025-02-26 05:22:29 -05:00
comfyanonymous
a9afb34b7b Slightly better wan i2v mask implementation. 2025-02-26 03:49:50 -05:00
comfyanonymous
94053d2ab3 WIP support for Wan I2V model. 2025-02-26 01:49:43 -05:00
comfyanonymous
6a7c4079a4 Wan seems to work with fp16. 2025-02-25 21:37:12 -05:00
comfyanonymous
4a783c2f63 Make wan work with all latent resolutions.
Cleanup some code.
2025-02-25 19:56:04 -05:00
comfyanonymous
f5990fa4c3 Fix issue with wan and other attention implementations. 2025-02-25 19:13:39 -05:00
comfyanonymous
65760e20d6 Change wan rope implementation to the flux one.
Should be more compatible.
2025-02-25 19:11:14 -05:00
comfyanonymous
3c67f6155a WIP support for Wan t2v model. 2025-02-25 17:20:35 -05:00
comfyanonymous
49a76acccf Cleanup some lumina te code. 2025-02-25 04:10:26 -05:00
comfyanonymous
114be728b1 Speedup on some models by not upcasting bfloat16 to float32 on mac. 2025-02-24 05:41:32 -05:00
comfyanonymous
8a7f84bbd2 Prioritize fp16 compute when using allow_fp16_accumulation 2025-02-23 04:45:54 -05:00
comfyanonymous
117cf08066 Remove some useless code. 2025-02-22 04:45:14 -05:00
comfyanonymous
67d7eeb002 Assume the mac black image bug won't be fixed before v16. 2025-02-21 20:24:07 -05:00
comfyanonymous
58a37f57b0 Latest mac still has the black image bug. 2025-02-21 20:14:30 -05:00
comfyanonymous
6ecbdae55b Let all model memory be offloaded on nvidia. 2025-02-21 06:32:21 -05:00
comfyanonymous
de308facd5 Apparently directml supports fp16. 2025-02-20 09:30:24 -05:00
Silver
1552d83834 Fix link pointing to non-exisiting docs (#6891)
* Fix link pointing to non-exisiting docs

The current link is pointing to a path that does not exist any longer.
I changed it to point to the currect correct path for custom nodes datatypes.

* Update node_typing.py
2025-02-20 07:07:07 -05:00
maedtb
50912cb296 Fix Hunyuan unet config detection for some models. (#6877)
The change to support 32 channel hunyuan models is missing the `key_prefix` on the key.

This addresses a complain in the comments of 0b5852ed5dd28fdf2a3efd2b670c871d24deb7f9.
2025-02-19 07:14:45 -05:00
bymyself
5b3f96785f Add Load Image Output node (#6790)
* add LoadImageOutput node

* add route for input/output/temp files

* update node_typing.py

* use literal type for image_folder field

* mark node as beta
2025-02-18 17:53:01 -05:00
Jukka Seppänen
0b5852ed5d Support loading and using SkyReels-V1-Hunyuan-I2V (#6862)
* Support SkyReels-V1-Hunyuan-I2V

* VAE scaling

* Fix T2V

oops

* Proper latent scaling
2025-02-18 17:06:54 -05:00
comfyanonymous
aa50906886 Fix typo.
Let me know if this slows things down on 2000 series and below.
2025-02-18 07:28:33 -05:00
comfyanonymous
4e37ad25fd Improve AMD arch detection. 2025-02-17 04:53:40 -05:00
comfyanonymous
4f1809faf8 bf16 manual cast works on old AMD. 2025-02-17 04:42:40 -05:00
comfyanonymous
e9c105523f Refactor torch version checks to be more future proof. 2025-02-17 04:36:45 -05:00
comfyanonymous
b02aa6ea50 Disable bf16 on AMD GPUs that don't support it. 2025-02-16 05:46:10 -05:00
comfyanonymous
539bc3e2e0 Disable pytorch attention in VAE for AMD. 2025-02-14 05:42:14 -05:00
comfyanonymous
98c0df4724 Auto enable mem efficient attention on gfx1100 on pytorch nightly 2.7
I'm not not sure which arches are supported yet. If you see improvements in
memory usage while using --use-pytorch-cross-attention on your AMD GPU let
me know and I will add it to the list.
2025-02-14 04:18:14 -05:00
comfyanonymous
451a692a3d Add a way to set a different compute dtype for the model at runtime.
Currently only works for diffusion models.
2025-02-13 20:34:03 -05:00
comfyanonymous
1f657be9a7 Better memory estimation for ROCm that support mem efficient attention.
There is no way to check if the card actually supports it so it assumes
that it does if you use --use-pytorch-cross-attention with yours.
2025-02-13 08:32:36 -05:00
comfyanonymous
66d579cd19 Fix ruff. 2025-02-12 06:49:16 -05:00
zhoufan2956
0f7eb12d62 mix_ascend_bf16_infer_err (#6794) 2025-02-12 06:48:11 -05:00
comfyanonymous
16bd3b8441 Add add_weight_wrapper function to model patcher.
Functions can now easily be added to wrap/modify model weights.
2025-02-12 05:55:35 -05:00
comfyanonymous
2a521a2e33 Cleanup. 2025-02-11 17:17:03 -05:00
HishamC
f49d8d3d1e Fix for running via DirectML (#6542)
* Fix for running via DirectML

Fix DirectML empty image generation issue with Flux1. add CPU fallback for unsupported path. Verified the model works on AMD GPUs

* fix formating

* update casual mask calculation
2025-02-11 17:11:32 -05:00
comfyanonymous
a7e5e662ab Make --force-fp16 actually force the diffusion model to be fp16. 2025-02-11 08:33:09 -05:00
comfyanonymous
6e2027a69b Make lumina model work with any latent resolution. 2025-02-10 00:24:20 -05:00
comfyanonymous
c80b2a425c Remove useless function. 2025-02-09 07:02:57 -05:00
Pam
a1cd544ace res_multistep: Fix cfgpp and add ancestral samplers (#6731) 2025-02-08 19:39:58 -05:00
comfyanonymous
84a5e51448 Make error more clear to user. 2025-02-08 18:57:24 -05:00
catboxanon
ca2a621e0b Allow FP16 accumulation with --fast (#6453)
Currently only applies to PyTorch nightly releases. (>=20250208)
2025-02-08 17:00:56 -05:00
comfyanonymous
6865c73a03 Don't compress http response by default.
Remove argument to disable it.

Add new --enable-compress-response-body argument to enable it.
2025-02-07 03:29:21 -05:00
comfyanonymous
1908648a5b Remove some useless code. 2025-02-06 05:00:37 -05:00
comfyanonymous
50a778e1ce Set the shift for Lumina back to 6. 2025-02-05 14:49:52 -05:00
comfyanonymous
ff7449847e Upcasting rope to fp32 seems to make no difference in this model. 2025-02-05 04:32:47 -05:00
comfyanonymous
f210ee69df Use regular numbers for rope in lumina model. 2025-02-05 04:17:25 -05:00
comfyanonymous
eaf581f1ed Fix lumina 2 batches. 2025-02-04 21:48:11 -05:00
comfyanonymous
0467641f12 Lower the default shift of lumina to reduce artifacts. 2025-02-04 06:50:37 -05:00
comfyanonymous
24b0e00898 Fix on python 3.9 2025-02-04 04:20:56 -05:00