1073 Commits

Author SHA1 Message Date
comfyanonymous
19cdff6796 Cleanup. 2024-08-30 12:53:59 -04:00
Chenlei Hu
2ff5eb9c72 Get logs endpoint & system_stats additions (#4690)
* Add route for getting output logs

* Include ComfyUI version

* Move to own function

* Changed to memory logger

* Unify logger setup logic

* Fix get version git fallback

---------

Co-authored-by: pythongosssss <125205205+pythongosssss@users.noreply.github.com>
2024-08-30 12:46:37 -04:00
comfyanonymous
573d09ea33 Fix potential issue with hydit controlnets. 2024-08-30 04:58:41 -04:00
comfyanonymous
ece9de35de Fix glora lowvram issue. 2024-08-29 19:07:23 -04:00
comfyanonymous
c3503e62bc Implement model part of flux union controlnet. 2024-08-29 18:41:22 -04:00
comfyanonymous
ee3374957b InstantX depth flux controlnet. 2024-08-29 02:14:19 -04:00
comfyanonymous
739d31c73a InstantX canny controlnet. 2024-08-28 19:02:50 -04:00
comfyanonymous
48a1a6ef98 Unify RMSNorm code. 2024-08-28 16:56:38 -04:00
comfyanonymous
a80296ecb6 Fix case where model was not properly unloaded in merging workflows. 2024-08-27 19:03:51 -04:00
Chenlei Hu
2f6fe893b3 Support weight padding on diff weight patch (#4576) 2024-08-27 13:55:37 -04:00
comfyanonymous
23922a2fbd Do RMSNorm in native type. 2024-08-27 02:41:56 -04:00
comfyanonymous
f2a13e96b4 Make the stochastic fp8 rounding reproducible. 2024-08-26 15:12:06 -04:00
comfyanonymous
6c7971a4d7 Use less memory in float8 lora patching by doing calculations in fp16. 2024-08-26 14:45:58 -04:00
comfyanonymous
0144d62aa9 Fix potential memory leak. 2024-08-26 02:07:32 -04:00
comfyanonymous
0911b077b3 Fix some controlnets OOMing when loading. 2024-08-25 05:54:29 -04:00
comfyanonymous
b9590ea077 Fix onnx export. 2024-08-23 17:52:47 -04:00
comfyanonymous
49cd4f5123 Fix dora. 2024-08-23 04:58:59 -04:00
comfyanonymous
65a577e0db Cleanup. 2024-08-23 04:06:27 -04:00
comfyanonymous
103d705247 Fix. 2024-08-23 04:04:55 -04:00
Simon Lui
24af9ec35a Rework IPEX check for future inclusion of XPU into Pytorch upstream and do a bit more optimization of ipex.optimize(). (#4562) 2024-08-23 03:59:57 -04:00
Scorpinaus
77841395ab Added SD15_Inpaint_Diffusers model support for unet_config_from_diffusers_unet function (#4565) 2024-08-23 03:57:08 -04:00
comfyanonymous
c6f6298c52 Missing imports. 2024-08-22 17:20:51 -04:00
comfyanonymous
59d0907512 Move calculate function to comfy.lora 2024-08-22 17:12:00 -04:00
comfyanonymous
23836e6596 Code cleanups. 2024-08-22 17:05:12 -04:00
comfyanonymous
7bad18b66d Fix issue with models staying loaded in memory. 2024-08-22 15:58:20 -04:00
comfyanonymous
262abf2310 Try to fix some lora issues. 2024-08-22 15:32:18 -04:00
David
ff022fccc2 Generalize MacOS version check for force-upcast-attention (#4548)
This code automatically forces upcasting attention for MacOS versions 14.5 and 14.6. My computer returns the string "14.6.1" for `platform.mac_ver()[0]`, so this generalizes the comparison to catch more versions.

I am running MacOS Sonoma 14.6.1 (latest version) and was seeing black image generation on previously functional workflows after recent software updates. This PR solved the issue for me.

See comfyanonymous/ComfyUI#3521
2024-08-22 13:24:21 -04:00
comfyanonymous
2e13ae7d8c Fix issue. 2024-08-22 10:38:24 -04:00
comfyanonymous
190a03c892 fp16 is actually faster than fp32 on a GTX 1080. 2024-08-21 23:23:50 -04:00
comfyanonymous
883e5a9aa5 Fix slow performance on 10 series Nvidia GPUs. 2024-08-21 16:39:02 -04:00
comfyanonymous
9c847187cb Try a different type of flux fp16 fix. 2024-08-21 16:17:15 -04:00
comfyanonymous
a1a6c213a5 Make --fast work on pytorch nightly. 2024-08-21 14:01:41 -04:00
Svein Ove Aas
b4bedcdc11 Replace use of .view with .reshape (#4522)
When generating images with fp8_e4_m3 Flux and batch size >1, using --fast, ComfyUI throws a "view size is not compatible with input tensor's size and stride" error pointing at the first of these two calls to view.

As reshape is semantically equivalent to view except for working on a broader set of inputs, there should be no downside to changing this. The only difference is that it clones the underlying data in cases where .view would error out. I have confirmed that the output still looks as expected, but cannot confirm that no mutable use is made of the tensors anywhere.

Note that --fast is only marginally faster than the default.
2024-08-21 11:21:48 -04:00
comfyanonymous
d8af5d17b5 Remove useless line, adjust windows default reserved vram. 2024-08-21 00:47:19 -04:00
comfyanonymous
6c68634351 Speed up fp8 matrix mult by using better code. 2024-08-20 22:53:26 -04:00
comfyanonymous
8addad7f2c Simpletrainer lycoris format. 2024-08-20 12:05:13 -04:00
comfyanonymous
7c0c89e70c Add --fast argument to enable experimental optimizations.
Optimizations that might break things/lower quality will be put behind
this flag first and might be enabled by default in the future.

Currently the only optimization is float8_e4m3fn matrix multiplication on
4000/ADA series Nvidia cards or later. If you have one of these cards you
will see a speed boost when using fp8_e4m3fn flux for example.
2024-08-20 11:55:51 -04:00
comfyanonymous
d30678a05e Support loading long clipl model with the CLIP loader node. 2024-08-20 10:46:36 -04:00
comfyanonymous
2062f06e50 Properly set if clip text pooled projection instead of using hack. 2024-08-20 10:46:36 -04:00
comfyanonymous
05938809a4 Make cast_to a nop if weight is already good. 2024-08-20 10:46:36 -04:00
comfyanonymous
c3bec99a9b Fix potential issue with multi devices. 2024-08-20 10:46:36 -04:00
comfyanonymous
f9c6ff16f7 New load_text_encoder_state_dicts function.
Now you can load text encoders straight from a list of state dicts.
2024-08-19 17:36:35 -04:00
comfyanonymous
5115d926eb Add a --reserve-vram argument if you don't want comfy to use all of it.
--reserve-vram 1.0 for example will make ComfyUI try to keep 1GB vram free.

This can also be useful if workflows are failing because of OOM errors but
in that case please report it if --reserve-vram improves your situation.
2024-08-19 17:16:18 -04:00
comfyanonymous
f2d98aa557 Bug fixes. 2024-08-19 16:28:55 -04:00
comfyanonymous
0f356a9212 Use better dtype for the lowvram lora system. 2024-08-19 15:35:25 -04:00
comfyanonymous
48335ad8ca Remove duplication. 2024-08-19 15:26:50 -04:00
comfyanonymous
f99d236347 Better subnormal fp8 stochastic rounding. Thanks Ashen. 2024-08-19 13:38:03 -04:00
comfyanonymous
939c35d580 Code cleanup. 2024-08-19 12:48:59 -04:00
comfyanonymous
7921766c26 Handle subnormal numbers in float8 rounding. 2024-08-19 05:51:08 -04:00
comfyanonymous
b35cfc0926 Less broken non blocking? 2024-08-18 16:53:17 -04:00