diff --git a/tests/entrypoints/llm/test_generate_multiple_loras.py b/tests/entrypoints/llm/test_generate_multiple_loras.py index 90e1d5814137..099af0f36088 100644 --- a/tests/entrypoints/llm/test_generate_multiple_loras.py +++ b/tests/entrypoints/llm/test_generate_multiple_loras.py @@ -23,7 +23,19 @@ LORA_NAME = "typeof/zephyr-7b-beta-lora" @pytest.fixture(scope="module") -def llm(): +def monkeypatch_module(): + from _pytest.monkeypatch import MonkeyPatch + mpatch = MonkeyPatch() + yield mpatch + mpatch.undo() + + +@pytest.fixture(scope="module", params=[False, True]) +def llm(request, monkeypatch_module): + + use_v1 = request.param + monkeypatch_module.setenv('VLLM_USE_V1', '1' if use_v1 else '0') + # pytest caches the fixture so we use weakref.proxy to # enable garbage collection llm = LLM(model=MODEL_NAME, diff --git a/tests/entrypoints/openai/test_lora_adapters.py b/tests/entrypoints/openai/test_lora_adapters.py index 1a62157acc47..2fc08b47513e 100644 --- a/tests/entrypoints/openai/test_lora_adapters.py +++ b/tests/entrypoints/openai/test_lora_adapters.py @@ -53,7 +53,20 @@ def zephyr_lora_files(): @pytest.fixture(scope="module") -def server_with_lora_modules_json(zephyr_lora_files): +def monkeypatch_module(): + from _pytest.monkeypatch import MonkeyPatch + mpatch = MonkeyPatch() + yield mpatch + mpatch.undo() + + +@pytest.fixture(scope="module", params=[False, True]) +def server_with_lora_modules_json(request, monkeypatch_module, + zephyr_lora_files): + + use_v1 = request.param + monkeypatch_module.setenv('VLLM_USE_V1', '1' if use_v1 else '0') + # Define the json format LoRA module configurations lora_module_1 = { "name": "zephyr-lora", diff --git a/vllm/entrypoints/openai/serving_models.py b/vllm/entrypoints/openai/serving_models.py index 38a66583022a..7a68452efc65 100644 --- a/vllm/entrypoints/openai/serving_models.py +++ b/vllm/entrypoints/openai/serving_models.py @@ -162,7 +162,7 @@ class OpenAIServingModels: except BaseException as e: error_type = "BadRequestError" status_code = HTTPStatus.BAD_REQUEST - if isinstance(e, ValueError) and "No adapter found" in str(e): + if "No adapter found" in str(e): error_type = "NotFoundError" status_code = HTTPStatus.NOT_FOUND