From 19c583398aec0ef2b9fe42ba020bc3c39e7e001f Mon Sep 17 00:00:00 2001 From: Harry Mellor <19981378+hmellor@users.noreply.github.com> Date: Thu, 18 Dec 2025 21:59:10 +0000 Subject: [PATCH] Check for truthy `rope_parameters` not the existence of it (#30983) Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com> --- vllm/transformers_utils/config.py | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/vllm/transformers_utils/config.py b/vllm/transformers_utils/config.py index a11d37b4b2edf..887f936a2d8ae 100644 --- a/vllm/transformers_utils/config.py +++ b/vllm/transformers_utils/config.py @@ -318,15 +318,15 @@ def patch_rope_parameters(config: PretrainedConfig) -> None: # Transformers v4 installed, legacy config fields may be present if (rope_scaling := getattr(config, "rope_scaling", None)) is not None: config.rope_parameters = rope_scaling + if ( + rope_theta is not None or partial_rotary_factor is not None + ) and not getattr(config, "rope_parameters", None): + config.rope_parameters = {"rope_type": "default"} if rope_theta is not None: - if not hasattr(config, "rope_parameters"): - config.rope_parameters = {"rope_type": "default"} config.rope_parameters["rope_theta"] = rope_theta if partial_rotary_factor is not None: - if not hasattr(config, "rope_parameters"): - config.rope_parameters = {"rope_type": "default"} config.rope_parameters["partial_rotary_factor"] = partial_rotary_factor - elif rope_theta is not None or hasattr(config, "rope_parameters"): + elif rope_theta is not None or getattr(config, "rope_parameters", None): # Transformers v5 installed # Patch these fields in case they used non-standard names if rope_theta is not None: