xinyun/vllm
1
0
Fork 0
mirror of https://git.datalinker.icu/vllm-project/vllm.git synced 2025-12-15 11:15:01 +08:00
Code Issues Packages Projects Releases Wiki Activity

Fix ValueError: Missing value for tag key(s): model_name,engine. (#19113)

Browse Source 
Signed-off-by: Seiji Eicher <seiji@anyscale.com>
This commit is contained in:
Seiji Eicher 2025-06-04 02:10:45 -07:00 committed by GitHub
parent 8e972d9c44
commit 2669a0d7b5
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 14 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
tests/v1/metrics/test_ray_metrics.py
View File

@ -47,12 +47,15 @@ def test_engine_log_metrics_ray(
engine_args, stat_loggers=[RayPrometheusStatLogger]) engine_args, stat_loggers=[RayPrometheusStatLogger])
for i, prompt in enumerate(example_prompts): for i, prompt in enumerate(example_prompts):
engine.generate( results = engine.generate(
request_id=f"request-id-{i}", request_id=f"request-id-{i}",
prompt=prompt, prompt=prompt,
sampling_params=SamplingParams(max_tokens=max_tokens), sampling_params=SamplingParams(max_tokens=max_tokens),
) )
async for _ in results:
pass
# Create the actor and call the async method # Create the actor and call the async method
actor = EngineTestActor.remote() # type: ignore[attr-defined] actor = EngineTestActor.remote() # type: ignore[attr-defined]
ray.get(actor.run.remote()) ray.get(actor.run.remote())

10
vllm/v1/metrics/ray_wrappers.py
View File

@ -31,6 +31,16 @@ class RayPrometheusMetric:
self.metric.set_default_tags(labelskwargs) self.metric.set_default_tags(labelskwargs)
if labels:
if len(labels) != len(self.metric._tag_keys):
raise ValueError(
"Number of labels must match the number of tag keys. "
f"Expected {len(self.metric._tag_keys)}, got {len(labels)}"
)
self.metric.set_default_tags(
dict(zip(self.metric._tag_keys, labels)))
return self return self