From 4789b9911024b894d99e34a31648c5453c252cbb Mon Sep 17 00:00:00 2001 From: Oscar Gonzalez Date: Mon, 22 Dec 2025 18:24:58 -0500 Subject: [PATCH] fix: resolve mypy type errors in isaac_patch_hf_runner Signed-off-by: Oscar Gonzalez --- .../models/multimodal/generation/test_isaac.py | 17 +++++++++++++---- 1 file changed, 13 insertions(+), 4 deletions(-) diff --git a/tests/models/multimodal/generation/test_isaac.py b/tests/models/multimodal/generation/test_isaac.py index cf3081696a630..7cc2cfb311572 100644 --- a/tests/models/multimodal/generation/test_isaac.py +++ b/tests/models/multimodal/generation/test_isaac.py @@ -145,9 +145,11 @@ def isaac_patch_hf_runner(hf_model: HfRunner) -> HfRunner: ) # Initialize and collect hidden states - all_hidden_states = () hidden_states = inputs_embeds - all_hidden_states += (hidden_states,) + hidden_states_list: list[torch.Tensor] = [] + + if output_hidden_states: + hidden_states_list.append(hidden_states) for decoder_layer in self.layers: layer_outputs = decoder_layer( @@ -164,11 +166,18 @@ def isaac_patch_hf_runner(hf_model: HfRunner) -> HfRunner: hidden_states = ( layer_outputs[0] if isinstance(layer_outputs, tuple) else layer_outputs ) - all_hidden_states += (hidden_states,) + + if output_hidden_states: + hidden_states_list.append(hidden_states) # Final layer norm hidden_states = self.norm(hidden_states) - all_hidden_states += (hidden_states,) + + if output_hidden_states: + hidden_states_list.append(hidden_states) + + # Convert to tuple or None + all_hidden_states = tuple(hidden_states_list) if output_hidden_states else None # Include hiden_states for compatibility with hidden_states_to_seq_logprobs() return BaseModelOutputWithPast(