[GC Debugger] Simply and improve GC Debugger Utils (#29029)

Signed-off-by: Jialin Ouyang <Jialin.Ouyang@gmail.com>
This commit is contained in:
Jialin Ouyang 2025-11-19 16:10:22 -08:00 committed by GitHub
parent 5031cd5d55
commit 537cc635c7
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 6 additions and 6 deletions

View File

@ -68,9 +68,10 @@ class GCDebugger:
# Before GC started, record GC start time
# and top collected objects
self.start_time_ns = time.monotonic_ns()
self.gc_top_collected_objects = _compute_top_gc_collected_objects(
gc.get_objects(generation), self.config.top_objects
)
if (top_objects := self.config.top_objects) > 0:
self.gc_top_collected_objects = _compute_top_gc_collected_objects(
gc.get_objects(generation), top_objects
)
elif phase == "stop":
# After GC finished, Record GC elapsed time and
# optionally top collected objects

View File

@ -206,6 +206,8 @@ class EngineCore:
# Mark the startup heap as static so that it's ignored by GC.
# Reduces pause times of oldest generation collections.
freeze_gc_heap()
# If enable, attach GC debugger after static variable freeze.
maybe_attach_gc_debug_callback()
def _initialize_kv_caches(
self, vllm_config: VllmConfig
@ -645,9 +647,6 @@ class EngineCoreProc(EngineCore):
assert addresses.coordinator_input is not None
logger.info("Waiting for READY message from DP Coordinator...")
# If enable, attach GC debugger after static variable freeze.
maybe_attach_gc_debug_callback()
# Enable environment variable cache (e.g. assume no more
# environment variable overrides after this point)
enable_envs_cache()