xinyun/vllm
1
0
Fork 0
mirror of https://git.datalinker.icu/vllm-project/vllm.git synced 2026-06-07 20:22:20 +08:00
Code Issues Packages Projects Releases Wiki Activity

[ROCM] Reorder arguments and rename parameters for rope_cached_thd_positions_2c_fwd_inplace

Browse Source 
The `is_nope_first` parameter is named `nope_first` in aiter.

First parameter ordering is query, key, cos, sin, positions.

Testing:
Use `VLLM_ROCM_USE_AITER_TRITON_ROPE=1`. Previously this failed; now
it runs.

Signed-off-by: Tres Popp <tres.popp@amd.com>
This commit is contained in:
Tres Popp 2025-12-03 20:13:43 +00:00
parent afe9eb408e
commit 5400baf42b
1 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
vllm/_aiter_ops.py
View File

@ -878,14 +878,14 @@ class rocm_aiter_ops:
key_ = key[..., :rotary_dim] key_ = key[..., :rotary_dim]
positions = positions.view(*query.shape[:1]) positions = positions.view(*query.shape[:1])
rope_cached_thd_positions_2c_fwd_inplace( rope_cached_thd_positions_2c_fwd_inplace(
positions,
sin,
cos,
query_, query_,
key_, key_,
sin,
cos,
positions,
rotate_style, rotate_style,
reuse_freqs_front_part=True, reuse_freqs_front_part=True,
is_nope_first=False, nope_first=False,
) )
query = query.view(query_shape) query = query.view(query_shape)
key = key.view(key_shape) key = key.view(key_shape)