From 5bb81e284b7cdbe7630cb49759beafcd64844c21 Mon Sep 17 00:00:00 2001
From: Simon Mo <simon.mo@hey.com>
Date: Thu, 17 Jul 2025 13:19:16 -0700
Subject: [PATCH] Change default request logging behavior

---
 vllm/engine/arg_utils.py | 33 +++++++++++++++++++++++++++++++--
 1 file changed, 31 insertions(+), 2 deletions(-)

diff --git a/vllm/engine/arg_utils.py b/vllm/engine/arg_utils.py
index ae5eb46fa9677..e99c69f73d7ec 100644
--- a/vllm/engine/arg_utils.py
+++ b/vllm/engine/arg_utils.py
@@ -1701,7 +1701,12 @@ class EngineArgs:
 @dataclass
 class AsyncEngineArgs(EngineArgs):
     """Arguments for asynchronous vLLM engine."""
-    disable_log_requests: bool = False
+    # Request logging is disabled by default.  ``--disable-log-requests`` is
+    # kept for backwards compatibility but has no effect.  ``--enable-legacy-
+    # log-requests`` can be used to restore the previous behaviour of logging
+    # each request.
+    disable_log_requests: bool = True
+    enable_legacy_log_requests: bool = False
 
     @staticmethod
     def add_cli_args(parser: FlexibleArgumentParser,
@@ -1714,10 +1719,34 @@ class AsyncEngineArgs(EngineArgs):
             parser = EngineArgs.add_cli_args(parser)
         parser.add_argument('--disable-log-requests',
                             action='store_true',
-                            help='Disable logging requests.')
+                            default=None,
+                            help='[DEPRECATED] Request logging is disabled by '
+                            'default.')
+        parser.add_argument('--enable-legacy-log-requests',
+                            action='store_true',
+                            help='Enable legacy request logging behavior.')
         current_platform.pre_register_and_update(parser)
         return parser
 
+    @classmethod
+    def from_cli_args(cls, args: argparse.Namespace):
+        engine_args = super().from_cli_args(args)
+
+        if args.enable_legacy_log_requests:
+            engine_args.disable_log_requests = False
+        else:
+            if args.disable_log_requests is None:
+                logger.warning(
+                    "Request logging is disabled by default. Use "
+                    "--enable-legacy-log-requests to restore the previous "
+                    "behaviour.")
+                engine_args.disable_log_requests = True
+            else:
+                engine_args.disable_log_requests = True
+
+        engine_args.enable_legacy_log_requests = args.enable_legacy_log_requests
+        return engine_args
+
 
 def _raise_or_fallback(feature_name: str, recommend_to_remove: bool):
     if envs.is_set("VLLM_USE_V1") and envs.VLLM_USE_V1: