From 68311891f5036a4faac89ead7dd40826d18da0b1 Mon Sep 17 00:00:00 2001
From: Harry Mellor <19981378+hmellor@users.noreply.github.com>
Date: Sat, 10 May 2025 14:23:00 +0100
Subject: [PATCH] Don't default construct `ModelConfig` when default
 constructing `VllmConfig` (#17943)

Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
---
 vllm/config.py | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/vllm/config.py b/vllm/config.py
index ef0163eaff85c..4a503665503aa 100644
--- a/vllm/config.py
+++ b/vllm/config.py
@@ -3954,7 +3954,9 @@ class VllmConfig:
     simplifies passing around the distinct configurations in the codebase.
     """
 
-    model_config: ModelConfig = field(default_factory=ModelConfig)
+    # TODO: use default_factory once default constructing ModelConfig doesn't
+    # try to download a model
+    model_config: ModelConfig = None  # type: ignore
     """Model configuration."""
     cache_config: CacheConfig = field(default_factory=CacheConfig)
     """Cache configuration."""