From 9bebc9512f9340e94579b9bd69cfdc452c4d5bb0 Mon Sep 17 00:00:00 2001 From: Roger Wang <136131678+ywang96@users.noreply.github.com> Date: Sun, 23 Feb 2025 05:32:20 -0800 Subject: [PATCH] [Misc] Deprecate `--dataset` from `benchmark_serving.py` (#13708) Signed-off-by: Roger Wang --- benchmarks/benchmark_serving.py | 23 ++++------------------- 1 file changed, 4 insertions(+), 19 deletions(-) diff --git a/benchmarks/benchmark_serving.py b/benchmarks/benchmark_serving.py index 9760737ccec3..9416a22b7357 100644 --- a/benchmarks/benchmark_serving.py +++ b/benchmarks/benchmark_serving.py @@ -867,18 +867,10 @@ def main(args: argparse.Namespace): tokenizer_mode=tokenizer_mode, trust_remote_code=args.trust_remote_code) - if args.dataset is not None: - warnings.warn( - "The '--dataset' argument will be deprecated in the next " - "release. Please use '--dataset-name' and " - "'--dataset-path' in the future runs.", - stacklevel=2) - input_requests = sample_sharegpt_requests( - dataset_path=args.dataset, - num_requests=args.num_prompts, - tokenizer=tokenizer, - fixed_output_len=args.sharegpt_output_len, - ) + if args.dataset_name is None: + raise ValueError( + "Please specify '--dataset-name' and the corresponding " + "'--dataset-path' if required.") elif args.dataset_name == "sharegpt": input_requests = sample_sharegpt_requests( @@ -1052,13 +1044,6 @@ if __name__ == "__main__": default="/v1/completions", help="API endpoint.", ) - parser.add_argument( - "--dataset", - type=str, - default=None, - help="Path to the ShareGPT dataset, will be deprecated in the " - "next release.", - ) parser.add_argument( "--dataset-name", type=str,