mirror of
https://git.datalinker.icu/vllm-project/vllm.git
synced 2026-06-03 21:42:19 +08:00
fix cross-node headless arg validation
Signed-off-by: Nick Hill <nhill@redhat.com>
This commit is contained in:
parent
75bd8ead71
commit
aca3ce6ba0
@ -690,6 +690,9 @@ def wait_for_engine_startup(
|
|||||||
poller = zmq.Poller()
|
poller = zmq.Poller()
|
||||||
poller.register(handshake_socket, zmq.POLLIN)
|
poller.register(handshake_socket, zmq.POLLIN)
|
||||||
|
|
||||||
|
remote_should_be_headless = not parallel_config.data_parallel_hybrid_lb \
|
||||||
|
and not parallel_config.data_parallel_external_lb
|
||||||
|
|
||||||
if proc_manager is not None:
|
if proc_manager is not None:
|
||||||
for sentinel in proc_manager.sentinels():
|
for sentinel in proc_manager.sentinels():
|
||||||
poller.register(sentinel, zmq.POLLIN)
|
poller.register(sentinel, zmq.POLLIN)
|
||||||
@ -733,15 +736,15 @@ def wait_for_engine_startup(
|
|||||||
f"{'local' if engine.local else 'remote'}")
|
f"{'local' if engine.local else 'remote'}")
|
||||||
|
|
||||||
# Remote engines must be headless iff we aren't in hybrid dp lb mode.
|
# Remote engines must be headless iff we aren't in hybrid dp lb mode.
|
||||||
if not local and headless == parallel_config.data_parallel_hybrid_lb:
|
if not local and headless != remote_should_be_headless:
|
||||||
if headless:
|
if headless:
|
||||||
raise RuntimeError(f"Remote engine {eng_index} must not use "
|
raise RuntimeError(f"Remote engine {eng_index} must not use "
|
||||||
f"--headless in --data-parallel-hybrid-lb "
|
f"--headless in external or hybrid dp lb "
|
||||||
f"mode")
|
f"mode")
|
||||||
else:
|
else:
|
||||||
raise RuntimeError(f"Remote engine {eng_index} must use "
|
raise RuntimeError(f"Remote engine {eng_index} must use "
|
||||||
f"--headless unless"
|
f"--headless unless in external or hybrid "
|
||||||
f"in --data-parallel-hybrid-lb mode")
|
f"dp lb mode")
|
||||||
|
|
||||||
if status == "HELLO" and engine.state == CoreEngineState.NEW:
|
if status == "HELLO" and engine.state == CoreEngineState.NEW:
|
||||||
|
|
||||||
|
|||||||
Loading…
x
Reference in New Issue
Block a user