[Bug][Benchmark] Fix duplicate req in oversampling (#26140)

Signed-off-by: Ekagra Ranjan <3116519+ekagra-ranjan@users.noreply.github.com>
Co-authored-by: Roger Wang <hey@rogerw.io>
This commit is contained in:
Ekagra Ranjan 2025-10-02 22:55:24 -04:00 committed by GitHub
parent 36ce76c632
commit ad2d788016
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194

View File

@ -235,16 +235,22 @@ class BenchmarkDataset(ABC):
if len(requests) < num_requests:
random.seed(self.random_seed)
additional = deepcopy(
random.choices(requests, k=num_requests - len(requests))
)
for i in range(len(additional)):
req = additional[i]
needed = num_requests - len(requests)
additional = []
for i in range(needed):
req = deepcopy(random.choice(requests))
req.request_id = request_id_prefix + str(len(requests) + i)
additional.append(req)
requests.extend(additional)
logger.info("Oversampled requests to reach %d total samples.",
num_requests)
ids = [req.request_id for req in requests]
if len(ids) != len(set(ids)):
raise ValueError("Duplicate request_id found in the sampled "
"requests. Please ensure that each request_id "
"is unique.")
# -----------------------------------------------------------------------------
# Utility Functions and Global Caches