xinyun/vllm
1
0
Fork 0
mirror of https://git.datalinker.icu/vllm-project/vllm.git synced 2026-03-21 12:29:21 +08:00
Code Issues Packages Projects Releases Wiki Activity

fix(core): break circular reference in Request using weakref to prevent memory leak

Browse Source 
Signed-off-by: Kelvin Velasquez <vv22015@ues.edu.sv>
This commit is contained in:
Kelvin Velasquez 2025-12-23 10:30:20 -06:00
parent 38c361f99d
commit b9968373c3
1 changed files with 4 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
vllm/v1/request.py
View File

@ -3,6 +3,7 @@
import enum
import time
import weakref
from collections.abc import Callable, Mapping
from functools import partial
from typing import TYPE_CHECKING, Any, Optional
@ -132,7 +133,9 @@ class Request:
self.block_hashes: list[BlockHash] = []
self.get_hash_new_full_blocks: Callable[[], list[BlockHash]] | None = None
if block_hasher is not None:
self.get_hash_new_full_blocks = partial(block_hasher, self)
# Use weakref to avoid circular reference: Request -> partial -> Request
# This allows immediate reclamation by refcounting without waiting for GC.
self.get_hash_new_full_blocks = partial(block_hasher, weakref.proxy(self))
self.block_hashes = self.get_hash_new_full_blocks()
self.skip_reading_prefix_cache = self.get_skip_reading_prefix_cache()