From b9b5bdfc7d5cd0f8610a4de7a79327d10a09dfab Mon Sep 17 00:00:00 2001 From: Rui Qiao <161574667+ruisearch42@users.noreply.github.com> Date: Sun, 16 Mar 2025 15:46:42 -0700 Subject: [PATCH] [Misc] Catching Ray Compiled Graph PP test failures for V1 (#14847) --- tests/distributed/test_pipeline_parallel.py | 20 +++++++++++++++----- 1 file changed, 15 insertions(+), 5 deletions(-) diff --git a/tests/distributed/test_pipeline_parallel.py b/tests/distributed/test_pipeline_parallel.py index 05b6ba40506a..4d3306509c8f 100644 --- a/tests/distributed/test_pipeline_parallel.py +++ b/tests/distributed/test_pipeline_parallel.py @@ -350,6 +350,10 @@ def _compare_tp( else: pp_env = None + tp_env = { + "VLLM_USE_V1": vllm_major_version, + } + pp_args = [ *common_args, "--pipeline-parallel-size", @@ -374,14 +378,20 @@ def _compare_tp( ] try: - compare_two_settings(model_id, pp_args, tp_args, pp_env, method=method) + compare_two_settings(model_id, + pp_args, + tp_args, + pp_env, + tp_env, + method=method) except Exception: - if pp_env is None: - raise - else: - # Ray Compiled Graph tests are flaky, + testing_ray_compiled_graph = pp_env is not None + if testing_ray_compiled_graph and vllm_major_version == "0": + # Ray Compiled Graph tests are flaky for V0, # so we don't want to fail the test logger.exception("Ray Compiled Graph tests failed") + else: + raise @pytest.mark.parametrize(