From cbedb703cc594632db796f9ca748ea4b7b4e8435 Mon Sep 17 00:00:00 2001 From: Yanan Cao Date: Sat, 6 Dec 2025 18:53:42 -0800 Subject: [PATCH] [Frontend] Remove confusing -O.xx flag error (#30169) Signed-off-by: Yanan Cao --- tests/utils_/test_argparse_utils.py | 19 ------------------- vllm/utils/argparse_utils.py | 7 ------- 2 files changed, 26 deletions(-) diff --git a/tests/utils_/test_argparse_utils.py b/tests/utils_/test_argparse_utils.py index 6f24c77e066a..fbc278404e3f 100644 --- a/tests/utils_/test_argparse_utils.py +++ b/tests/utils_/test_argparse_utils.py @@ -458,22 +458,3 @@ def test_flat_product(): (3, 4, "a", 5, 6), (3, 4, "b", 5, 6), ] - - -def test_o_dotted_syntax_error(): - """Test that -O.* dotted syntax raises a clear error message.""" - parser = FlexibleArgumentParser() - parser.add_argument("-cc", "--compilation-config", type=json.loads) - - # Test that -O.* syntax raises a clear ValueError - with pytest.raises(ValueError, match=r"The -O\.\* syntax is no longer supported"): - parser.parse_args(["-O.backend=eager"]) - - with pytest.raises(ValueError, match=r"Please use -cc\.\* instead"): - parser.parse_args(["-O.mode=2"]) - - with pytest.raises( - ValueError, - match=r"replace '-O\.cudagraph_mode=NONE' with '-cc\.cudagraph_mode=NONE'", - ): - parser.parse_args(["-O.cudagraph_mode=NONE"]) diff --git a/vllm/utils/argparse_utils.py b/vllm/utils/argparse_utils.py index 356f383cc52b..87ee6f54c0c9 100644 --- a/vllm/utils/argparse_utils.py +++ b/vllm/utils/argparse_utils.py @@ -244,13 +244,6 @@ class FlexibleArgumentParser(ArgumentParser): else: key = pattern.sub(repl, arg, count=1) processed_args.append(key) - elif arg.startswith("-O."): - # Provide clear error for deprecated -O.* syntax - raise ValueError( - f"The -O.* syntax is no longer supported. " - f"Please use -cc.* instead. " - f"For example, replace '{arg}' with '{arg.replace('-O', '-cc', 1)}'" - ) elif arg.startswith("-O") and arg != "-O": # allow -O flag to be used without space, e.g. -O3 or -Odecode # also handle -O= here