From 5400baf42bbfcab12cd256757deee5b6b4998834 Mon Sep 17 00:00:00 2001 From: Tres Popp Date: Wed, 3 Dec 2025 20:13:43 +0000 Subject: [PATCH 1/2] [ROCM] Reorder arguments and rename parameters for rope_cached_thd_positions_2c_fwd_inplace The `is_nope_first` parameter is named `nope_first` in aiter. First parameter ordering is query, key, cos, sin, positions. Testing: Use `VLLM_ROCM_USE_AITER_TRITON_ROPE=1`. Previously this failed; now it runs. Signed-off-by: Tres Popp --- vllm/_aiter_ops.py | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/vllm/_aiter_ops.py b/vllm/_aiter_ops.py index a8f472d147a0d..025f588a92f2b 100644 --- a/vllm/_aiter_ops.py +++ b/vllm/_aiter_ops.py @@ -878,14 +878,14 @@ class rocm_aiter_ops: key_ = key[..., :rotary_dim] positions = positions.view(*query.shape[:1]) rope_cached_thd_positions_2c_fwd_inplace( - positions, - sin, - cos, query_, key_, + sin, + cos, + positions, rotate_style, reuse_freqs_front_part=True, - is_nope_first=False, + nope_first=False, ) query = query.view(query_shape) key = key.view(key_shape) From d56cdd9cd302940dcda965b8053a1fc2a347e5d9 Mon Sep 17 00:00:00 2001 From: Tres Popp Date: Mon, 15 Dec 2025 14:27:21 +0000 Subject: [PATCH 2/2] Fix swapped cos/sin --- vllm/_aiter_ops.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/vllm/_aiter_ops.py b/vllm/_aiter_ops.py index 025f588a92f2b..76c10010c5b6a 100644 --- a/vllm/_aiter_ops.py +++ b/vllm/_aiter_ops.py @@ -880,8 +880,8 @@ class rocm_aiter_ops: rope_cached_thd_positions_2c_fwd_inplace( query_, key_, - sin, cos, + sin, positions, rotate_style, reuse_freqs_front_part=True,