From dd1a50a8bc520b0e52ce7914f0263ebd576c197f Mon Sep 17 00:00:00 2001 From: "Li, Jiang" Date: Wed, 1 May 2024 07:33:33 +0800 Subject: [PATCH] [Bugfix][Minor] Make ignore_eos effective (#4468) --- vllm/sampling_params.py | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/vllm/sampling_params.py b/vllm/sampling_params.py index 0ed6a01a62212..f6e7a3ca792e4 100644 --- a/vllm/sampling_params.py +++ b/vllm/sampling_params.py @@ -275,7 +275,8 @@ class SamplingParams: self, generation_config: Dict[str, Any]) -> None: """Update if there are non-default values from generation_config""" # Update eos_token_id for generation - if eos_ids := generation_config.get("eos_token_id"): + if (not self.ignore_eos) and (eos_ids := + generation_config.get("eos_token_id")): # it can be either int or list of int if isinstance(eos_ids, int): eos_ids = [eos_ids]