From e497f33491671abbf94a3e563d55ca2818ee09db Mon Sep 17 00:00:00 2001 From: Russell Bryant Date: Sun, 2 Feb 2025 02:35:50 -0500 Subject: [PATCH] [Core] Silence unnecessary deprecation warnings (#12620) I noticed during testing that I was getting a lot of these deprecation warnings about `local_lora_path`: ``` DeprecationWarning: The 'lora_local_path' attribute is deprecated and will be removed in a future version. Please use 'lora_path' instead. ``` The check used for emitting this warning was always True, even when the parameter was not actually specified. It will always be in `__struct_fields__`. We should be checking for a non-None value, instead. Signed-off-by: Russell Bryant Signed-off-by: Russell Bryant --- vllm/lora/request.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/vllm/lora/request.py b/vllm/lora/request.py index c4b26dc92c6f4..5e3d2f0ed211b 100644 --- a/vllm/lora/request.py +++ b/vllm/lora/request.py @@ -31,7 +31,7 @@ class LoRARequest( base_model_name: Optional[str] = msgspec.field(default=None) def __post_init__(self): - if 'lora_local_path' in self.__struct_fields__: + if self.lora_local_path: warnings.warn( "The 'lora_local_path' attribute is deprecated " "and will be removed in a future version. "